Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store secret keys in the OS keychain. #617

Closed
NodeGuy opened this issue Mar 13, 2018 · 2 comments
Closed

Store secret keys in the OS keychain. #617

NodeGuy opened this issue Mar 13, 2018 · 2 comments

Comments

@NodeGuy
Copy link
Contributor

NodeGuy commented Mar 13, 2018

Apologies if this has already been implemented/considered.

@jessysaurusrex suggested that we store secret keys in the OS keychain (using, e.g., https://github.com/zalando/go-keyring).

Given that the OS already prompts the user for a password to unlock the keychain, does this mean we don't need to send a password to the SDK from the client?

@ebuchman: Thoughts?

@mappum
Copy link
Contributor

mappum commented Mar 14, 2018

I like this idea 👍

Given that the OS already prompts the user for a password to unlock the keychain, does this mean we don't need to send a password to the SDK from the client?

We would still need some way for the LCD to authenticate Voyager so other processes can't get it to sign malicious transactions, so the Electron<->LCD connection would stay the same.

@jackzampolin
Copy link
Member

If we are going to implement this its going to be part of a much more thorough going refactor of our wallet functionality. Platform specific wallets are a bit of a ways out. Going to close this as stale. Please reopen if you feel otherwise.

chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this issue Mar 1, 2024
* Bump github.com/spf13/cobra from 1.1.1 to 1.1.2

Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.1.1 to 1.1.2.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Changelog](https://github.com/spf13/cobra/blob/master/CHANGELOG.md)
- [Commits](spf13/cobra@v1.1.1...v1.1.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* go.sum

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Federico Kunze <federico.kunze94@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants