Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add staking pool tests #731

Closed
rigelrozanski opened this issue Mar 28, 2018 · 1 comment · Fixed by #754
Closed

add staking pool tests #731

rigelrozanski opened this issue Mar 28, 2018 · 1 comment · Fixed by #754
Assignees
@rigelrozanski @cwgoes
Labels
C:x/staking

Comments

@rigelrozanski
Copy link
Contributor

tests for all the functions in x/stake/pool.go
@rigelrozanski
Copy link
Contributor Author

Based on conversation....

  • Move get/set pool to keeper.go
  • Make all other functions methods of the Pool struct
  • explicitly return the updated pool, and updated candidate as return values from those functions (aka. do not write to the store - store writes to be done in handler/tick.go)
    @cwgoes

@cwgoes cwgoes mentioned this issue Mar 30, 2018
Merged
rigelrozanski pushed a commit that referenced this issue Mar 30, 2018
@cwgoes @rigelrozanski
Staking pool tests (closes #731)
ede04a2
@rigelrozanski rigelrozanski mentioned this issue Mar 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rigelrozanski rigelrozanski

@cwgoes cwgoes

Labels
C:x/staking
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

staking tests cosmos/cosmos-sdk
2 participants
@rigelrozanski @cwgoes