-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ADR 028 and Address Follow-ups #7618
Comments
/cc @robert-zaremba |
I will be happy to handle this task. I like it. |
It'd be good to add recommended prefix sizes or explain why the size wouldn't matter, ref |
Has ADR 28 been implemented? Is there a different issue to track it? I see unchecked tasks on this issue and the ADR documents the status as For the IBC application called Interchain Accounts, we need to generate account addresses using the portIDs. This is the same issue we ran into for the IBC transfer module. In that case, a manual check that none of the escrow addresses used would collide was sufficient, but I'm wondering if there is a more sustainable fix in place? |
ADR-28 is implemented and being released in v0.43. I've just updated the checkboxes.
|
Awesome, thank you for the response @robert-zaremba! |
Nice to have
Follow-ups (out of scope for v0.42)
The text was updated successfully, but these errors were encountered: