Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ADR 028 and Address Follow-ups #7618

Closed
7 of 8 tasks
aaronc opened this issue Oct 21, 2020 · 6 comments
Closed
7 of 8 tasks

Implement ADR 028 and Address Follow-ups #7618

aaronc opened this issue Oct 21, 2020 · 6 comments
Assignees
Labels
Milestone

Comments

@aaronc
Copy link
Member

aaronc commented Oct 21, 2020

Nice to have

Follow-ups (out of scope for v0.42)

@aaronc aaronc added this to the v0.41 milestone Oct 21, 2020
@aaronc aaronc added the backlog label Oct 21, 2020
@aaronc
Copy link
Member Author

aaronc commented Oct 22, 2020

/cc @robert-zaremba

@robert-zaremba
Copy link
Collaborator

I will be happy to handle this task. I like it.

@robert-zaremba robert-zaremba self-assigned this Oct 22, 2020
@colin-axner
Copy link
Contributor

It'd be good to add recommended prefix sizes or explain why the size wouldn't matter, ref

@colin-axner
Copy link
Contributor

Has ADR 28 been implemented? Is there a different issue to track it? I see unchecked tasks on this issue and the ADR documents the status as Proposed

For the IBC application called Interchain Accounts, we need to generate account addresses using the portIDs. This is the same issue we ran into for the IBC transfer module. In that case, a manual check that none of the escrow addresses used would collide was sufficient, but I'm wondering if there is a more sustainable fix in place?

@robert-zaremba
Copy link
Collaborator

robert-zaremba commented Aug 11, 2021

ADR-28 is implemented and being released in v0.43. I've just updated the checkboxes.

@colin-axner
Copy link
Contributor

Awesome, thank you for the response @robert-zaremba!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants