Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICA module addresses may conflict #303

Closed
3 tasks
colin-axner opened this issue Jul 27, 2021 · 2 comments
Closed
3 tasks

ICA module addresses may conflict #303

colin-axner opened this issue Jul 27, 2021 · 2 comments
Assignees
@damiannolan @colin-axner
Labels
27-interchain-accounts
Milestone
Interchain Accounts

Comments

@colin-axner
Copy link
Contributor

colin-axner commented Jul 27, 2021 •
edited
Loading

Summary

ICA addresses may conflict with other module addresses based on the current construction (A hash of the counterparty portID ics27-<connectionID>-<counterpartyConnectionID>-<owneraddress>. This was a concern with ICS20 and there was a lot of discussion and extra checking that went into ensuring the proposed solutions was safe. We need to revisit this issue for Interchain Accounts. Ideally the changes in v0.43 of SDK allow us to use some sort of prefixed address

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added this to the Interchain Accounts milestone Jul 27, 2021
@colin-axner colin-axner self-assigned this Aug 5, 2021
@colin-axner
Copy link
Contributor Author

see comment

Each interchain account address created should be a sub account of the module account owned by the interchain module

This was referenced Sep 15, 2021
Merged
Merged
@damiannolan damiannolan self-assigned this Sep 22, 2021
@damiannolan
Copy link
Contributor

Closed by #428

@crodriguezvega crodriguezvega moved this to Done in ibc-go Dec 30, 2021
faddat pushed a commit to notional-labs/ibc-go that referenced this issue Mar 1, 2022
@fedekunze
Merge pull request cosmos#303 from cosmos/fedekunze/update-demos
4a2e46d 
update relayer demos
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@tzdybal
Map LastBlockID.Hash to LastHeaderHash in conversion (cosmos#303)
5d8f737
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiannolan damiannolan

@colin-axner colin-axner

Labels
27-interchain-accounts
Projects
ibc-go
Archived in project
Milestone
Interchain Accounts
Development

No branches or pull requests
3 participants
@damiannolan @crodriguezvega @colin-axner