-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solomachine PubKey fixes #7823
Comments
cc @colin-axner do you have any opinions here? |
multiPK, ok := pubKey.(multisig.PubKey)
if !ok {
return sdkerrors.Wrapf(ErrSignatureVerificationFailed, "invalid pubkey type: expected %T, got %T", (multisig.PubKey)(nil), pubKey)
} Multsigs cause the public key to be casted to a multsig pk, this will fail and the error above will be returned. |
I suggest that we switch on pubkey type instead. switch on multipubkey and then check inside that case that the signature is a multisignature before calling Since I don't believe there is a separate interface for single pubkeys this can be the default case, |
Sorry, I was going off of this. Proposed solution sounds fine. |
The text was updated successfully, but these errors were encountered: