Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solo machine GetPubKey returns an error instead of panicing #7883

Merged
merged 5 commits into from
Nov 11, 2020

Conversation

colin-axner
Copy link
Contributor

@colin-axner colin-axner commented Nov 10, 2020

Description

closes: #7823


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #7883 (5f70bd5) into master (0bd4657) will increase coverage by 0.00%.
The diff coverage is 66.10%.

@@           Coverage Diff           @@
##           master    #7883   +/-   ##
=======================================
  Coverage   54.20%   54.21%           
=======================================
  Files         610      610           
  Lines       38847    38868   +21     
=======================================
+ Hits        21056    21071   +15     
- Misses      15636    15639    +3     
- Partials     2155     2158    +3     

Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM. Pending a few unit test cases

Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@colin-axner colin-axner added the A:automerge Automatically merge PR once all prerequisites pass. label Nov 11, 2020
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@mergify mergify bot merged commit 116d046 into master Nov 11, 2020
@mergify mergify bot deleted the colin/7823-sm-fixes-part2 branch November 11, 2020 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solomachine PubKey fixes
3 participants