Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update relevant docs to remove usage of bech32 pubkeys, and document new Any usage #8053

Closed
6 of 7 tasks
robert-zaremba opened this issue Dec 1, 2020 · 5 comments · Fixed by #8895 or #9006
Closed
6 of 7 tasks
Assignees
Labels
T:Docs Changes and features related to documentation.
Milestone

Comments

@robert-zaremba
Copy link
Collaborator

robert-zaremba commented Dec 1, 2020

Summary

We don't have a clear documentation how to serialize data with regards to pub keys

Ref: #7447


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@robert-zaremba robert-zaremba added the T:Docs Changes and features related to documentation. label Dec 1, 2020
@robert-zaremba robert-zaremba self-assigned this Dec 1, 2020
@amaury1093 amaury1093 self-assigned this Feb 23, 2021
@amaury1093 amaury1093 added this to the v0.42 milestone Feb 23, 2021
@amaury1093
Copy link
Contributor

@robert-zaremba The item "adr-019-protobuf-state-encoding.md" is done already, correct? I see correct mentions of MarshalInterface for marshaling interface with any. Was there something else you wanted to add?

@amaury1093
Copy link
Contributor

When reading ADR-019, it did mention HybridCodec, which was removed, so i created #8683.

@robert-zaremba
Copy link
Collaborator Author

@robert-zaremba The item "adr-019-protobuf-state-encoding.md" is done already, correct? I see correct mentions of MarshalInterface for marshaling interface with any. Was there something else you wanted to add?

Yes, we updated it for MarshalInterface, but here we should mostly check if we need to update mentions related to bech32

@amaury1093
Copy link
Contributor

Understood. I believe the pubkey encoding bech32->any only happened in the Validator. I went through adr 019 and 020, there's no mention (and imo, no need to mention) of bech32 in those 2 ADRs.

I updated adr 020 to mention our new PubKey types in #8683

@amaury1093
Copy link
Contributor

amaury1093 commented Mar 25, 2021

I closed too prematurely. There are some mentions of bech32 pubkeys in https://docs.cosmos.network/master/basics/accounts.html. i can take care of that once #7477 is merged

See 1st post for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:Docs Changes and features related to documentation.
Projects
None yet
4 participants