Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update bech32 account docs #9006

Merged
merged 3 commits into from
Mar 29, 2021
Merged

docs: update bech32 account docs #9006

merged 3 commits into from
Mar 29, 2021

Conversation

robert-zaremba
Copy link
Collaborator

Description

closes: #8053


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I did a ctrl+F on the whole codebase, found these occurrences:

  • docs/core/node.md:L20: "addresses and pubkeys"
  • docs/spec/addresses/bech32.md: still some pubkeys

@amaury1093 amaury1093 added the T:Docs Changes and features related to documentation. label Mar 26, 2021
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mergify mergify bot merged commit 823620c into master Mar 29, 2021
@mergify mergify bot deleted the robert/pk-docs branch March 29, 2021 11:22
@orijbot
Copy link

orijbot commented Mar 29, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:Store T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update relevant docs to remove usage of bech32 pubkeys, and document new Any usage
5 participants