Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find or create overflow-proof safe arithmetic library #869

Closed
cwgoes opened this issue Apr 16, 2018 · 8 comments
Closed

Find or create overflow-proof safe arithmetic library #869

cwgoes opened this issue Apr 16, 2018 · 8 comments
Assignees

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Apr 16, 2018

Ref #694

Put this in tmlibs and make sure we use it.

@cwgoes cwgoes self-assigned this Apr 17, 2018
@rigelrozanski
Copy link
Contributor

What does this entail that errors are returned instead of panics? Do we really need this if we're catching all panics within SDK already?

@cwgoes
Copy link
Contributor Author

cwgoes commented Apr 26, 2018

Panics are fine - probably preferable - they just need to happen instead of overflows.

@rigelrozanski
Copy link
Contributor

......... does go arithmetic not panic on overflows? https://medium.com/@griffinish/integer-overflow-in-golang-9e13e274c8a5
Guess not>
This article suggests this library in it https://github.com/JohnCGriffin/overflow

@rigelrozanski
Copy link
Contributor

but again we should probably not import but add it ourselves to tmlibs or whatever

@cwgoes
Copy link
Contributor Author

cwgoes commented Jun 7, 2018

Less necessary because of #977, still a good idea where we aren't using big.Int though.

@ebuchman
Copy link
Member

Do we still want to do this? Or just push everything through big.Int?

@rigelrozanski
Copy link
Contributor

  • for everything through big.Int

@cwgoes
Copy link
Contributor Author

cwgoes commented Jun 20, 2018

I think we can close this for now. If end users want to use non-big.Int types and demand later emerges for such a library, we can reconsider.

@cwgoes cwgoes closed this as completed Jun 20, 2018
chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this issue Mar 1, 2024
* Create interchain staking lightpaper DRAFT

* Update docs/interchain-staking.md

Co-authored-by: Aditya <adityasripal@gmail.com>

* Update docs/interchain-staking.md

* Update docs/interchain-staking.md

Co-authored-by: Aditya <adityasripal@gmail.com>

* Update docs/interchain-staking.md

* Update and rename interchain-staking.md to interchain-security.md

* Update interchain-security.md

Co-authored-by: Aditya <adityasripal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants