-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find or create overflow-proof safe arithmetic library #869
Comments
What does this entail that errors are returned instead of panics? Do we really need this if we're catching all panics within SDK already? |
Panics are fine - probably preferable - they just need to happen instead of overflows. |
......... does go arithmetic not panic on overflows? https://medium.com/@griffinish/integer-overflow-in-golang-9e13e274c8a5 |
but again we should probably not import but add it ourselves to tmlibs or whatever |
Less necessary because of #977, still a good idea where we aren't using |
Do we still want to do this? Or just push everything through big.Int? |
|
I think we can close this for now. If end users want to use non- |
* Create interchain staking lightpaper DRAFT * Update docs/interchain-staking.md Co-authored-by: Aditya <adityasripal@gmail.com> * Update docs/interchain-staking.md * Update docs/interchain-staking.md Co-authored-by: Aditya <adityasripal@gmail.com> * Update docs/interchain-staking.md * Update and rename interchain-staking.md to interchain-security.md * Update interchain-security.md Co-authored-by: Aditya <adityasripal@gmail.com>
Ref #694
Put this in
tmlibs
and make sure we use it.The text was updated successfully, but these errors were encountered: