-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amino support for x/authz & x/feegrant #9417
Labels
Milestone
Comments
I think more and more modules are being written with no amino. I have written a few that has removed or not added amino at all. I think saying the same for new modules makes sense. We should just expedite the sign mode that fixes it |
I think we should add for now but I also think we should expedite sign mode textual. |
aaronc
added
the
C:Ledger
Issues and features related Ledger integration and functionality
label
May 28, 2021
I'll take this issue. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Summary
Should we add amino support for x/authz and x/feegrant Msgs ?
Problem
The current state of x/authz and x/feegrant is that their Msgs don't support legacy amino JSON signing.
The reasons for this were primarily:
ServiceMsg
s (but this design has since been changed, see ADR-031: reconsider type url format for service msgs encoded as google.Protobuf.Any #9063).So whereas the SDK as a whole still supports legacy amino JSON, some modules inside it don't. Ledger users won't be able to sign authz and feegrant Msgs.
Proposals
Either we fully support amino:
+
Ledger support-
more legacy code lying aroundOr we fully document which modules in the SDK support legacy amino, and which don't
+
Less code change needed, v0.43 will be out sooner-
no ledger supportFor Admin Use
The text was updated successfully, but these errors were encountered: