Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] legacy amino support for authz module #498

Closed
yun-yeo opened this issue Jun 11, 2021 · 1 comment · Fixed by #499
Closed

[FEATURE] legacy amino support for authz module #498

yun-yeo opened this issue Jun 11, 2021 · 1 comment · Fixed by #499
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@yun-yeo
Copy link
Contributor

yun-yeo commented Jun 11, 2021

Problem definition
Columbus-4 has msgauth module, which is authz module in cosmos-sdk. cosmos-sdk fixed their implementation to support amino encoding for authz messages here.

Now we can add custom codec to authz messages to support old style tx signing.

func RegisterLegacyAminoCodec(cdc *codec.LegacyAmino) {
	cdc.RegisterInterface((*authz.Authorization)(nil), nil)

	cdc.RegisterConcrete(authz.MsgGrant{}, "msgauth/MsgGrantAuthorization", nil)
	cdc.RegisterConcrete(authz.MsgRevoke{}, "msgauth/MsgRevokeAuthorization", nil)
	cdc.RegisterConcrete(authz.MsgExec{}, "msgauth/MsgExecAuthorized", nil)
	cdc.RegisterConcrete(banktypes.SendAuthorization{}, "msgauth/SendAuthorization", nil)
	cdc.RegisterConcrete(authz.GenericAuthorization{}, "msgauth/GenericAuthorization", nil)
}

Feature specification
Add custom codec to support msgauth message amino signing.

Additional context
v0.5.x

@yun-yeo yun-yeo added the enhancement New feature or request label Jun 11, 2021
@yun-yeo yun-yeo self-assigned this Jun 11, 2021
@yun-yeo yun-yeo added this to the Columbus-5 milestone Jun 11, 2021
@yun-yeo
Copy link
Contributor Author

yun-yeo commented Jun 14, 2021

track cosmos/cosmos-sdk#9501

@hanjukim hanjukim linked a pull request Jun 14, 2021 that will close this issue
8 tasks
@yun-yeo yun-yeo closed this as completed Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant