Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double "Denom" in DenomMetadata key #9643

Closed
4 tasks
denight opened this issue Jul 7, 2021 · 0 comments · Fixed by #9890
Closed
4 tasks

Double "Denom" in DenomMetadata key #9643

denight opened this issue Jul 7, 2021 · 0 comments · Fixed by #9890
Assignees
@aleem1314
Labels
T:Bug T: Performance Performance improvements T: State Machine Breaking State machine breaking changes (impacts consensus).

Comments

@denight
Copy link

denight commented Jul 7, 2021

Summary of Bug

It looks like DenomMetadata is stored under the key DenomMetadataPrefix + Denom + Denom

Version

v0.42.6

Steps to Reproduce

https://github.com/cosmos/cosmos-sdk/blob/v0.42.6/x/bank/keeper/keeper.go#L232-L235

// effective prefix is DenomMetadataPrefix + Denom
denomMetaDataStore := prefix.NewStore(store, types.DenomMetadataKey(denomMetaData.Base)) 
// ...
// DenomMetadataPrefix + Denom + Denom
denomMetaDataStore.Set([]byte(denomMetaData.Base), m)

looks like should be

denomMetaDataStore := prefix.NewStore(store, types.DenomMetadataPrefix)

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@clevinson clevinson added T:Bug T: Performance Performance improvements T: State Machine Breaking State machine breaking changes (impacts consensus). labels Jul 9, 2021
@clevinson clevinson added this to the v0.44 milestone Jul 9, 2021
@aleem1314 aleem1314 self-assigned this Aug 10, 2021
@aleem1314 aleem1314 mentioned this issue Aug 10, 2021
Merged
19 tasks
@mergify mergify bot closed this as completed in #9890 Aug 11, 2021
mergify bot pushed a commit that referenced this issue Aug 11, 2021
@aleem1314
fix!: remove denom from DenomMetadata key (#9890)
c14b101 
<!--
The default pull request template is for types feat, fix, or refactor.
For other templates, add one of the following parameters to the url:
- template=docs.md
- template=other.md
-->

## Description

Closes: #9643 

<!-- Add a description of the changes that this PR introduces and the files that
are the most critical to review. -->

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [x] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [x] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [x] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aleem1314 aleem1314

Labels
T:Bug T: Performance Performance improvements T: State Machine Breaking State machine breaking changes (impacts consensus).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix!: remove denom from DenomMetadata key cosmos/cosmos-sdk
3 participants
@denight @clevinson @aleem1314