Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make sequence flag work on its own #9784

Closed
4 tasks
likhita-809 opened this issue Jul 27, 2021 · 4 comments · Fixed by #9856
Closed
4 tasks

feat: make sequence flag work on its own #9784

likhita-809 opened this issue Jul 27, 2021 · 4 comments · Fixed by #9856
Assignees
@likhita-809

Comments

@likhita-809
Copy link
Contributor

ref: #9407
--sequence doesn't work on its own, requires offline and account-number (often need to overwrite the sequence to sign a bunch of sequential multisig txs before they all broadcast)

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@likhita-809 likhita-809 self-assigned this Jul 27, 2021
@alexanderbez
Copy link
Contributor

Yes, this is intentional. Are you requesting that tx signing allow online mode with -s or -a?

@likhita-809
Copy link
Contributor Author

Yes, this is intentional. Are you requesting that tx signing allow online mode with -s or -a?

I'm not sure about this. Maybe @ebuchman can answer since he mentioned this issue.

@likhita-809 likhita-809 mentioned this issue Jul 28, 2021
Closed
20 tasks
@likhita-809
Copy link
Contributor Author

Yes, this is intentional. Are you requesting that tx signing allow online mode with -s or -a?

@ebuchman any comments ?

@amaury1093
Copy link
Contributor

amaury1093 commented Aug 3, 2021 •
edited
Loading

My preference for this issue would be:

  • to throw an error if --(sequence OR account-number) is not set with --offline=true
  • if --offline=false and --(sequence OR account-number) is set, overwrite with flag value
  • probably improve CLI help messages around these

@likhita-809 likhita-809 mentioned this issue Aug 5, 2021
Merged
19 tasks
@mergify mergify bot closed this as completed in #9856 Aug 9, 2021
mergify bot pushed a commit that referenced this issue Aug 9, 2021
@likhita-809
fix: overwrite sequence and account-number flags when used with offli…
59f63a2 
…ne=false (#9856)


## Description

Closes: #9784 

Overwrite --sequence and --account-number flags by default flag values, when used with offline=false in sign-batch command.

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@likhita-809 likhita-809

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: overwrite sequence and account-number flags when used with offline=false cosmos/cosmos-sdk
3 participants
@amaury1093 @alexanderbez @likhita-809