Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: remove grpc query routing through tendermint (backport #10045) #10269

Merged
merged 4 commits into from
Oct 4, 2021

Commits on Sep 30, 2021

  1. fix!: remove grpc query routing through tendermint (#10045)

    <!--
    The default pull request template is for types feat, fix, or refactor.
    For other templates, add one of the following parameters to the url:
    - template=docs.md
    - template=other.md
    -->
    
    ## Description
    
    Revert routing queries through tendermint.
    
    The reason this change was made is because of this error:
    ```
    fatal error: concurrent map read and map write
    ```
    
    The person who identified this error submitted these steps to reproduce
    ```
    User sends a query with grpc
    Tendermint Commit new blocks and tries to Commit IAVL (which causing IAVL versions map to change)
    At the same time query tries to read from the same map (iavl.(*MutableTree).VersionExists) to check if requested version is exists
    Node exits with fatal error: concurrent map read and map write
    ```
    
    With the recent changes to IAVL submitted by terra (cc @YunSuk-Yeo) the reason for why we need to route through tendermint is no longer present. We should revert it when 0.17.1 of IAVL is cut, which will be later today.
    
    ---
    
    ### Author Checklist
    
    *All items are required. Please add a note to the item if the item is not applicable and
    please add links to any relevant follow up issues.*
    
    I have...
    
    - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
    - [ ] added `!` to the type prefix if API or client breaking change
    - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
    - [ ] provided a link to the relevant issue or specification
    - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
    - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
    - [ ] added a changelog entry to `CHANGELOG.md`
    - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
    - [ ] updated the relevant documentation or specification
    - [ ] reviewed "Files changed" and left comments if necessary
    - [ ] confirmed all CI checks have passed
    
    ### Reviewers Checklist
    
    *All items are required. Please add a note if the item is not applicable and please add
    your handle next to the items reviewed if you only reviewed selected items.*
    
    I have...
    
    - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
    - [ ] confirmed `!` in the type prefix if API or client breaking change
    - [ ] confirmed all author checklist items have been addressed
    - [ ] reviewed state machine logic
    - [ ] reviewed API design and naming
    - [ ] reviewed documentation is accurate
    - [ ] reviewed tests and test coverage
    - [ ] manually tested (if applicable)
    
    (cherry picked from commit 8091846)
    
    # Conflicts:
    #	CHANGELOG.md
    tac0turtle authored and mergify-bot committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    c50ecea View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2021

  1. fix conflicts

    tac0turtle committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    208c97a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f417c0e View commit details
    Browse the repository at this point in the history
  3. revert

    tac0turtle committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    3b0091c View commit details
    Browse the repository at this point in the history