Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix comment on DenomMetadata for 0.44 #10408

Merged
merged 2 commits into from
Oct 20, 2021

Conversation

webmaster128
Copy link
Member

Probably a leftover from 0.44 -> 0.45 renaming. Just verified the double key is still there two times in the key in simapp 0.44.2.

@webmaster128 webmaster128 force-pushed the fix-comment-on-DenomMetadata-keys branch from 2eab4eb to 2eb9dca Compare October 20, 2021 13:20
@webmaster128 webmaster128 changed the title Fix comment on DenomMetadata for 0.44 chore: Fix comment on DenomMetadata for 0.44 Oct 20, 2021
@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #10408 (2eab4eb) into master (85eed1f) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 2eab4eb differs from pull request most recent head 86c8ee0. Consider uploading reports for the commit 86c8ee0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10408      +/-   ##
==========================================
+ Coverage   64.38%   64.42%   +0.03%     
==========================================
  Files         573      573              
  Lines       54625    54625              
==========================================
+ Hits        35172    35190      +18     
+ Misses      17457    17438      -19     
- Partials     1996     1997       +1     
Impacted Files Coverage Δ
x/distribution/simulation/operations.go 90.27% <0.00%> (+9.72%) ⬆️

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Oct 20, 2021
@mergify mergify bot merged commit bbe724e into cosmos:master Oct 20, 2021
creachadair pushed a commit that referenced this pull request Oct 21, 2021
Probably a leftover from 0.44 -> 0.45 renaming. Just verified the double key is still there two times in the key in simapp 0.44.2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/bank
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants