Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fedekunze/update rtd #1054

Closed
wants to merge 14 commits into from
Closed

WIP: Fedekunze/update rtd #1054

wants to merge 14 commits into from

Conversation

zramsay
Copy link
Contributor

@zramsay zramsay commented May 24, 2018

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md

@zramsay zramsay requested a review from ebuchman as a code owner May 24, 2018 18:11
@cwgoes
Copy link
Contributor

cwgoes commented May 25, 2018

Thanks; can we summarize the documentation updates in a changelog entry?

@zramsay zramsay changed the title Fedekunze/update rtd WIP: Fedekunze/update rtd May 25, 2018
@fedekunze fedekunze self-assigned this May 26, 2018
@fedekunze fedekunze added the T:Docs Changes and features related to documentation. label May 26, 2018
@ebuchman ebuchman added the wip label Jun 15, 2018
@ebuchman
Copy link
Member

Oy sorry I didn't see this before. @fedekunze can we get a summary of how this relates to the larger docs story of #1078 and #1376 ? Is there stuff to salvage from here ? Or should we just close ?

@cwgoes cwgoes changed the base branch from develop to unstable July 3, 2018 21:17
@cwgoes cwgoes changed the base branch from unstable to develop July 4, 2018 19:28
@ebuchman
Copy link
Member

ebuchman commented Jul 5, 2018

Closing this for now but will leave the branch.

@ebuchman ebuchman closed this Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants