Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump db dependencies #10542

Merged
merged 5 commits into from
Nov 15, 2021
Merged

chore: bump db dependencies #10542

merged 5 commits into from
Nov 15, 2021

Conversation

cmwaters
Copy link
Contributor

@cmwaters cmwaters commented Nov 15, 2021

Separated out the db dependency changes from: #10210.

Might need to wait till after #10210 is merged


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle
Copy link
Member

this can be merged without the Tendermint update right?

@tac0turtle
Copy link
Member

I think we can this go.mod to dependabot

@tac0turtle
Copy link
Member

@cmwaters can you add

- package-ecosystem: gomod
  directory: "/db"
  schedule:
    interval: daily
  open-pull-requests-limit: 10
  ``` to the dependant file?

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like the build is failing. LGTM pending ci fixes

@cmwaters
Copy link
Contributor Author

I think we can this go.mod to dependabot

Will we need to do this with container and cosmovisor which also contain their own go mod files

@github-actions github-actions bot added the T: CI label Nov 15, 2021
@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Nov 15, 2021
@mergify mergify bot merged commit ccd94b8 into master Nov 15, 2021
@mergify mergify bot deleted the callum/bump-db-dep branch November 15, 2021 14:13
@tac0turtle
Copy link
Member

I think we can this go.mod to dependabot

Will we need to do this with container and cosmovisor which also contain their own go mod files

yes we will add later

blewater pushed a commit to e-money/cosmos-sdk that referenced this pull request Dec 8, 2021
Separated out the db dependency changes from: cosmos#10210.

Might need to wait till after cosmos#10210 is merged


---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. T: CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants