-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: 0.44.4 release notes #10613
chore: 0.44.4 release notes #10613
Conversation
RELEASE_NOTES.md
Outdated
|
||
This release notably also: | ||
Other bug fixes: | ||
+ query account balance by ibc denom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually a client-breaking change for HTTP clients. We should document that better:
- /bank/v1beta1/balances/{address}/{ibc_denom}
+ /bank/v1beta1/balances/{address}/by_denom?denom={ibc_denom}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I've added more details. I'm not sure if we should link PRs here - these are in the changelog.
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm pending comments being resolved
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
* 0.44.4 Release Notes * Update RELEASE_NOTES.md Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> * review updates * Update CHANGELOG.md Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> * Update RELEASE_NOTES.md Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
* 0.44.4 Release Notes * Update RELEASE_NOTES.md Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> * review updates * Update CHANGELOG.md Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> * Update RELEASE_NOTES.md Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Description
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change