Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: gov sims to use v1beta2 #11069

Merged
merged 8 commits into from
Feb 2, 2022
Merged

refactor: gov sims to use v1beta2 #11069

merged 8 commits into from
Feb 2, 2022

Conversation

atheeshp
Copy link
Contributor

Description

Closes: #10986


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@atheeshp atheeshp changed the title refactor: gov sims refactor: gov sims to v1beta2 Jan 31, 2022
@atheeshp atheeshp changed the title refactor: gov sims to v1beta2 refactor: gov sims to use v1beta2 Feb 1, 2022
@atheeshp atheeshp marked this pull request as ready for review February 1, 2022 13:15
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

let's wait for sims to pass before merging

Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🎉 - Sims scare me

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:Simulations C:x/gov
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update gov simulations to use v1beta2.Proposal
3 participants