feat!: deprecate auth/types.NewModuleAddress

[robert-zaremba]

Description

Closes: #10225

Implementing the option 2:

• deprecate NewModuleAddress (and update SDK to not use it in any place) and remove in the subsequent release (1.0).

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[tac0turtle]

closing this as there is an open discussion on it. lets reopen when the work is ready to be worked on

[robert-zaremba]

The goal of this PR is to deprecate the NewModuleAddr and remove it the following release. In the future we should use an new module account type. In the meantime users can use the legacy function which this PR introduces.
Maybe this is premature and not needed? What do you think @alexanderbez , @aaronc