Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate fastcache #11180

Closed
wants to merge 1 commit into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Feb 14, 2022

Description

Closes: #XXXX

This will add the -fast changes from the osmosis team to v0.45.1.

I'm going to do the same with iavl, and the like. The improvement is very much worth the changes, though it is notable that these are breaking changes and I'm not 100% sure how to handle.

(hence draft)

Also this draft PR still relies on some osmosis-versioned libraries like iavl. I have not really asked anyone but was given green light long ago "to upstream stuff" so this is just a WIP pr doing that.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle changed the title Draft: V0.45.1 allfast feat: integrate fastcache Feb 14, 2022
@tac0turtle
Copy link
Member

thank you for making this PR. Id prefer not to break any apis and just backport the new iavl version and tm-db versions. Most of these changes shouldn't be needed.

Also the rule of thumb is merge to master than backport.

@faddat
Copy link
Contributor Author

faddat commented Feb 20, 2022

<3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants