Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup old migrations and legacy code #11205

Closed
wants to merge 2 commits into from

Conversation

robert-zaremba
Copy link
Collaborator

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle
Copy link
Member

is there a status here? if its not ready or there isn't time to get it reviewed lets close it

@robert-zaremba
Copy link
Collaborator Author

The status is to get feedback. I asked about it in the Discord 2 weeks ago.

@tac0turtle
Copy link
Member

The status is to get feedback. I asked about it in the Discord 2 weeks ago.

Lets discuss today on the sdk call. Would love to have consensus on this

@tac0turtle
Copy link
Member

in the sdk call we decided not to move forward with this. After framework wg has completed we will revisit this

@tac0turtle tac0turtle closed this Mar 12, 2022
@robert-zaremba
Copy link
Collaborator Author

No, we decided to leave 0.42+ migrations but to remove the older ones.

@tac0turtle
Copy link
Member

closing in favour of #11556, it leaves everything 0.42 and above

@tac0turtle tac0turtle closed this Apr 6, 2022
@julienrbrt julienrbrt deleted the robert/remove-legacy branch October 10, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants