Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove replace from cosmovisor/go.mod #11218

Closed
wants to merge 1 commit into from

Conversation

robert-zaremba
Copy link
Collaborator

Description

Closes: #10378


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the C:Cosmovisor Issues and PR related to Cosmovisor label Feb 17, 2022
@tac0turtle
Copy link
Member

There is a pr for this already #11212 please review

@tac0turtle
Copy link
Member

This fails cause it relies on the sdk. You can import the sdk without the replace directive

@robert-zaremba
Copy link
Collaborator Author

This fails cause it relies on the sdk. You can import the sdk without the replace directive

Something else must be wrong. All the apps are importing SDK and put that replace directive. The difference is that user don't install the Cosmos Apps using go install ..., but rather downloading the binary or building locally.

@robert-zaremba robert-zaremba changed the title remove replace from cosmovisor/go.mod fix: remove replace from cosmovisor/go.mod Feb 18, 2022
@tac0turtle
Copy link
Member

closing this as its not possible to remove replace without removing the sdk as a dependency.

@tac0turtle tac0turtle closed this Feb 21, 2022
@tac0turtle tac0turtle deleted the robert/fix-cosmovisor-gomod branch March 25, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Cosmovisor Issues and PR related to Cosmovisor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up cosmovisor to use x/upgrade as a dependency
2 participants