fix(cli): submit-legacy-proposal: return propoer error if no flag is provided
#11287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleem1314
requested review from
amaury1093,
anilcse,
atheeshp and
likhita-809
amaury1093
approved these changes
Feb 28, 2022
atheeshp
approved these changes
Feb 28, 2022
anilcse
reviewed
Feb 28, 2022
| func parseSubmitLegacyProposalFlags(fs *pflag.FlagSet) (*legacyProposal, error) { | ||
| proposal := &legacyProposal{} | ||
| proposalFile, _ := fs.GetString(FlagProposal) | ||
|
|
||
| if proposalFile == "" { | ||
| proposalType, _ := fs.GetString(FlagProposalType) | ||
| title, _ := fs.GetString(FlagTitle) | ||
| description, _ := fs.GetString(FlagDescription) | ||
| if proposalType == "" && title == "" && description == "" { |
There was a problem hiding this comment.
do we still need this? validate is already doing this right?
There was a problem hiding this comment.
I added this check to return a more user-friendly error.
There was a problem hiding this comment.
so this error would say one of three have an issue but the other error would say specifically what the error is right?
tac0turtle
added
the
A:automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #10624
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change