Release 0.6.0

.gitignore

@@ -1,3 +1,5 @@
 *.swp
 vendor
 merkleeyes.db
+build
+shunit2

CHANGELOG.md

@@ -1,5 +1,32 @@
 # Changelog
 
+## 0.6.0 (???)
+
+Make the basecli command the only way to use client-side, to enforce best
+security practices. Lots of enhancements to get it up to production quality.
+
+BREAKING CHANGES:
+- basecli
+  - `basecli proof state get` -> `basecli query key`
+  - `basecli proof tx get` -> `basecli query tx`
+  - `basecli proof state get --app=account` -> `basecli query account`
+  - use `--chain-id` not `--chainid` for consistency
+  - update to use `--trace` not `--debug` for stack traces on errors
+  - complete overhaul on how tx and query subcommands are added. (see counter or trackomatron for examples)
+  - no longer supports counter app (see new countercli)
+- basecoin
+  - removed all client side functionality from it (use basecli now for proofs)
+
+ENHANCEMENTS:
+- intergrates tendermint 0.10.0 (not the rc-2, but the real thing)
+- commands return error code (1) on failure for easier script testing
+- add `reset_all` to basecli, and never delete keys on `init`
+- new shutil based unit tests, with better coverage of the cli actions
+
+BUG FIXES:
+- no longer panics on missing app_options in genesis (thanks, anton)
+
+
 ## 0.5.2 (June 2, 2017)
 
 BUG FIXES:

Makefile

@@ -1,6 +1,8 @@
-all: test install
+GOTOOLS =	github.com/mitchellh/gox \
+			github.com/Masterminds/glide
+PACKAGES=$(shell go list ./... | grep -v '/vendor/')
 
-NOVENDOR = go list ./... | grep -v /vendor/
+all: get_vendor_deps install test
 
 build:
 	go build ./cmd/...
@@ -9,28 +11,37 @@ install:
 	go install ./cmd/...
 
 dist:
-	@ sudo bash scripts/dist.sh
-	@ bash scripts/publish.sh
+	@bash scripts/dist.sh
+	@bash scripts/publish.sh
 
-test:
-	go test `${NOVENDOR}`
-	#go run tests/tendermint/*.go
+test: test_unit test_cli
 
-get_deps:
-	go get -d ./...
+test_unit:
+	go test $(PACKAGES)
+	#go run tests/tendermint/*.go
 
-update_deps:
-	go get -d -u ./...
+test_cli: tests/cli/shunit2
+	# sudo apt-get install jq
+	@./tests/cli/basictx.sh
+	@./tests/cli/counter.sh
+	@./tests/cli/ibc.sh
 
-get_vendor_deps:
-	go get github.com/Masterminds/glide
+get_vendor_deps: tools
 	glide install
 
 build-docker:
-	docker run -it --rm -v "$(PWD):/go/src/github.com/tendermint/basecoin" -w "/go/src/github.com/tendermint/basecoin" -e "CGO_ENABLED=0" golang:alpine go build ./cmd/basecoin
+	docker run -it --rm -v "$(PWD):/go/src/github.com/tendermint/basecoin" -w \
+		"/go/src/github.com/tendermint/basecoin" -e "CGO_ENABLED=0" golang:alpine go build ./cmd/basecoin
 	docker build -t "tendermint/basecoin" .
 
+tests/cli/shunit2:
+	wget "https://raw.githubusercontent.com/kward/shunit2/master/source/2.1/src/shunit2" \
+		-q -O tests/cli/shunit2
+
+tools:
+	go get -u -v $(GOTOOLS)
+
 clean:
 	@rm -f ./basecoin
 
-.PHONY: all build install test get_deps update_deps get_vendor_deps build-docker clean
+.PHONY: all build install test test_cli test_unit get_vendor_deps build-docker clean

app/genesis.go

@@ -37,6 +37,7 @@ func (app *Basecoin) LoadGenesis(path string) error {
 		r := app.SetOption(kv.Key, kv.Value)
 		app.logger.Info("Done setting Plugin key-value pair via SetOption", "result", r, "k", kv.Key, "v", kv.Value)
 	}
+
 	return nil
 }
 
@@ -71,6 +72,10 @@ func loadGenesis(filePath string) (*FullGenesisDoc, error) {
 		return nil, errors.Wrap(err, "unmarshaling genesis file")
 	}
 
+	if genDoc.AppOptions == nil {
+		genDoc.AppOptions = new(GenesisDoc)
+	}
+
 	pluginOpts, err := parseGenesisList(genDoc.AppOptions.PluginOptions)
 	if err != nil {
 		return nil, err

app/genesis_test.go

@@ -8,14 +8,21 @@ import (
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 	"github.com/tendermint/basecoin/types"
-	"github.com/tendermint/go-crypto"
+	crypto "github.com/tendermint/go-crypto"
 	eyescli "github.com/tendermint/merkleeyes/client"
 	cmn "github.com/tendermint/tmlibs/common"
 )
 
 const genesisFilepath = "./testdata/genesis.json"
 const genesisAcctFilepath = "./testdata/genesis2.json"
 
+func TestLoadGenesisDoNotFailIfAppOptionsAreMissing(t *testing.T) {
+	eyesCli := eyescli.NewLocalClient("", 0)
+	app := NewBasecoin(eyesCli)
+	err := app.LoadGenesis("./testdata/genesis3.json")
+	require.Nil(t, err, "%+v", err)
+}
+
 func TestLoadGenesis(t *testing.T) {
 	assert, require := assert.New(t), require.New(t)
 

app/testdata/genesis3.json

@@ -0,0 +1,3 @@
+{
+  "chain_id": "foo_bar_chain"
+}

circle.yml

@@ -19,9 +19,8 @@ dependencies:
 
 test:
   override:
-    - "cd $REPO && glide install && go install ./cmd/basecoin"
+    - "cd $REPO && glide install && go install ./cmd/..."
     - ls $GOPATH/bin
     - "cd $REPO && make test"
-    - "cd $REPO/demo && bash start.sh"
 
 

cmd/basecli/LIGHT_NODE.md

@@ -21,7 +21,7 @@ Just initialize your client with the proper validator set as in the [README](REA
 
 ```
 $ export BCHOME=~/.lightnode
-$ basecli init --node tcp://<host>:<port> --chainid <chain>
+$ basecli init --node tcp://<host>:<port> --chain-id <chain>
 ```
 
 ## Running

cmd/basecli/README.md

@@ -40,7 +40,7 @@ $ basecoin start
 ## Connect your basecli the first time
 
 ```
-% basecli init --chainid test_chain_id --node tcp://localhost:46657
+% basecli init --chain-id test_chain_id --node tcp://localhost:46657
 ```
 
 ## Check your balances...