Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add store name in tracekv-emitted store traces #11646

Merged
merged 4 commits into from
Apr 14, 2022

Conversation

gsora
Copy link
Contributor

@gsora gsora commented Apr 14, 2022

Description

This PR adds the store name to each tracekv-emitted trace, making store tracing a little more useful and reliable for end-users.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@gsora
Copy link
Contributor Author

gsora commented Apr 14, 2022

Paging relevant stakeholders: @gamarin2 @sgerogia and @Pitasi.

@alessio alessio merged commit ce44b35 into cosmos:master Apr 14, 2022
@robert-zaremba robert-zaremba added the backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release label Apr 25, 2022
@robert-zaremba
Copy link
Collaborator

@Mergifyio backport release/v0.46.x

@mergify
Copy link
Contributor

mergify bot commented Apr 25, 2022

backport release/v0.46.x

❌ No backport have been created

  • Backport to branch release/v0.46.x failed: Git reported the following error:
fatal: couldn't find remote ref master

@robert-zaremba
Copy link
Collaborator

@Mergifyio backport release/v0.46.x

@mergify
Copy link
Contributor

mergify bot commented Apr 25, 2022

backport release/v0.46.x

❌ No backport have been created

  • Backport to branch release/v0.46.x failed: Git reported the following error:
fatal: couldn't find remote ref master

@robert-zaremba
Copy link
Collaborator

@Mergifyio backport release/v0.46.x

@mergify
Copy link
Contributor

mergify bot commented Apr 26, 2022

backport release/v0.46.x

❌ No backport have been created

  • Backport to branch release/v0.46.x failed: Git reported the following error:
fatal: couldn't find remote ref master

robert-zaremba pushed a commit that referenced this pull request Apr 26, 2022
* feature: Clone and Merge methods on TraceContext

* chore: use TraceContext.Merge method in SetTracingContext

* feature: add Store name in TraceContext during execution

* chore: update rootmulti Store TraceContext on *Store after Merge()
@robert-zaremba robert-zaremba mentioned this pull request Apr 26, 2022
19 tasks
robert-zaremba pushed a commit that referenced this pull request Apr 27, 2022
* feature: Clone and Merge methods on TraceContext

* chore: use TraceContext.Merge method in SetTracingContext

* feature: add Store name in TraceContext during execution

* chore: update rootmulti Store TraceContext on *Store after Merge()
@tac0turtle
Copy link
Member

@Mergifyio backport release/v0.45.x

@mergify
Copy link
Contributor

mergify bot commented Dec 1, 2022

backport release/v0.45.x

❌ No backport have been created

  • Backport to branch release/v0.45.x failed: Git reported the following error:
fatal: couldn't find remote ref master

alpe added a commit to CosmWasm/cosmos-sdk that referenced this pull request Dec 2, 2022
alpe added a commit to CosmWasm/cosmos-sdk that referenced this pull request Dec 2, 2022
tac0turtle pushed a commit that referenced this pull request Dec 5, 2022
* feature: Clone and Merge methods on TraceContext

* chore: use TraceContext.Merge method in SetTracingContext

* feature: add Store name in TraceContext during execution

* chore: update rootmulti Store TraceContext on *Store after Merge()
tac0turtle added a commit that referenced this pull request Dec 5, 2022
* feat: add store name in `tracekv`-emitted store traces (#11646)

* feature: Clone and Merge methods on TraceContext

* chore: use TraceContext.Merge method in SetTracingContext

* feature: add Store name in TraceContext during execution

* chore: update rootmulti Store TraceContext on *Store after Merge()

* add changelog entry

Co-authored-by: Gianguido Sorà <gsora@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release C:Store
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants