Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix TestNewAnyWithCustomTypeURLWithErrorNoAllocation test failure #11715

Merged
merged 2 commits into from
Apr 21, 2022
Merged

test: fix TestNewAnyWithCustomTypeURLWithErrorNoAllocation test failure #11715

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4af9f54
tests: fix TestNewAnyWithCustomTypeURLWithErrorNoAllocation failure
julienrbrt Apr 21, 2022
34c128a
Merge branch 'master' into julien/11664-tests-testnewanywithcustomtyp…
alexanderbez Apr 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions codec/types/any_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ var eom = &errOnMarshal{}
// Ensure that returning an error doesn't suddenly allocate and waste bytes.
// See https://github.com/cosmos/cosmos-sdk/issues/8537
func TestNewAnyWithCustomTypeURLWithErrorNoAllocation(t *testing.T) {
// make sure we're not in the middle of a GC.
runtime.GC()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the fix is just to run garbage collection prior to future runtime calls, I see.


var ms1, ms2 runtime.MemStats
runtime.ReadMemStats(&ms1)
any, err := types.NewAnyWithValue(eom)
Expand Down