chore: x/upgrade audit changes #11879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blushi
commented
May 5, 2022
| @@ -160,8 +159,9 @@ Ref: https://keepachangelog.com/en/1.0.0/ | |||
| * [\#11274](https://github.com/cosmos/cosmos-sdk/pull/11274) `types/errors.New` now is an alias for `types/errors.Register` and should only be used in initialization code. | |||
| * (authz)[\#11060](https://github.com/cosmos/cosmos-sdk/pull/11060) `authz.NewMsgGrant` `expiration` is now a pointer. When `nil` is used then no expiration will be set (grant won't expire). | |||
| * (x/distribution)[\#11457](https://github.com/cosmos/cosmos-sdk/pull/11457) Add amount field to `distr.MsgWithdrawDelegatorRewardResponse` and `distr.MsgWithdrawValidatorCommissionResponse`. | |||
| * [\#11334](https://github.com/cosmos/cosmos-sdk/pull/11334) Move `x/gov/types/v1beta2` to `x/gov/types/v1`. | |||
There was a problem hiding this comment.
not strictly related to x/upgrade but reviewing the changelog, I realized that we didn't have any item for x/gov v1beta2 -> v1 change
blushi
requested review from
amaury1093,
atheeshp,
JeancarloBarrios and
likhita-809
58 tasks
Codecov Report
@@ Coverage Diff @@
## main #11879 +/- ##
==========================================
- Coverage 66.03% 65.89% -0.15%
==========================================
Files 672 675 +3
Lines 70718 70965 +247
==========================================
+ Hits 46702 46759 +57
- Misses 21345 21530 +185
- Partials 2671 2676 +5
|
alexanderbez
approved these changes
May 5, 2022
|
Ditto on this being backported as a result of the 0.46 audit? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref: #11362
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change