Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: audit testutil #11954

Merged
merged 10 commits into from
May 13, 2022
Merged

chore: audit testutil #11954

merged 10 commits into from
May 13, 2022

Conversation

blushi
Copy link
Contributor

@blushi blushi commented May 13, 2022

Description

Ref: #11362


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

testutil/network/util.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #11954 (af4f013) into main (7a31a28) will decrease coverage by 0.30%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11954      +/-   ##
==========================================
- Coverage   66.28%   65.98%   -0.31%     
==========================================
  Files         690      677      -13     
  Lines       72282    71329     -953     
==========================================
- Hits        47910    47063     -847     
+ Misses      21665    21583      -82     
+ Partials     2707     2683      -24     
Impacted Files Coverage Δ
testutil/mock/privval.go 70.00% <ø> (ø)
testutil/network/network.go 62.40% <ø> (ø)
testutil/network/util.go 66.66% <0.00%> (-0.91%) ⬇️
container/struct_args.go
container/provider_desc.go
container/module_dep.go
container/container.go
container/simple.go
container/group.go
... and 11 more

@blushi blushi marked this pull request as ready for review May 13, 2022 11:25
@blushi blushi requested a review from a team as a code owner May 13, 2022 11:25
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, i also prefer returning an error than panicking

testutil/network/util.go Outdated Show resolved Hide resolved
testutil/network/util.go Outdated Show resolved Hide resolved
testutil/network/util.go Outdated Show resolved Hide resolved
blushi and others added 2 commits May 13, 2022 16:28
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
@blushi blushi added the A:automerge Automatically merge PR once all prerequisites pass. label May 13, 2022
@mergify mergify bot merged commit 16c8e27 into main May 13, 2022
@mergify mergify bot deleted the marie/11362-testutil branch May 13, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants