Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cli grants-by-grantee, grants-by-granter cmds #11983

Merged
merged 14 commits into from
May 19, 2022
Merged

fix: cli grants-by-grantee, grants-by-granter cmds #11983

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
577e978
fix: cli `grantee-grants`, `granter-grants` cmds
atheeshp May 18, 2022
caa5e2d
Merge branch 'main' into ap/feegrant-cli
alexanderbez May 18, 2022
0cd55a9
Merge branch 'main' into ap/feegrant-cli
alexanderbez May 18, 2022
4715637
Merge branch 'main' into ap/feegrant-cli
amaury1093 May 18, 2022
b35538e
Merge branch 'main' into ap/feegrant-cli
JeancarloBarrios May 18, 2022
9136ab3
Merge branch 'main' into ap/feegrant-cli
atheeshp May 19, 2022
50fe15c
review changes
atheeshp May 19, 2022
99de8d7
update changelog
atheeshp May 19, 2022
5b66b58
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/feegrant-cli
atheeshp May 19, 2022
6f01ef4
Merge branch 'ap/feegrant-cli' of github.com:cosmos/cosmos-sdk into a…
atheeshp May 19, 2022
49cd696
review changes
atheeshp May 19, 2022
d81cd2b
Update CHANGELOG.md
atheeshp May 19, 2022
80cae80
Update CHANGELOG.md
alexanderbez May 19, 2022
8c1f5e7
Merge branch 'main' into ap/feegrant-cli
alexanderbez May 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
* (x/feegrant) [\#11813](https://github.com/cosmos/cosmos-sdk/pull/11813) Fix pagination total count in `AllowancesByGranter` query.
* (simapp) [\#11855](https://github.com/cosmos/cosmos-sdk/pull/11855) Use `sdkmath.Int` instead of `int64` for `SimulationState.InitialStake`.
* (x/capability) [\#11737](https://github.com/cosmos/cosmos-sdk/pull/11737) Use a fixed length encoding of `Capability` pointer for `FwdCapabilityKey`
* (x/feegrant) [\#11983](https://github.com/cosmos/cosmos-sdk/pull/11983) fix `grants-by-grantee`, `grants-by-granter` cmds
atheeshp marked this conversation as resolved.
Show resolved Hide resolved

### State Machine Breaking

Expand Down
8 changes: 4 additions & 4 deletions x/authz/client/cli/query.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,13 +96,13 @@ $ %s query %s grants cosmos1skjw.. cosmos1skjwj.. %s

func GetQueryGranterGrants() *cobra.Command {
cmd := &cobra.Command{
Use: "granter-grants [granter-addr]",
Use: "grants-by-granter [granter-addr]",
Args: cobra.ExactArgs(1),
Short: "query authorization grants granted by granter",
Long: strings.TrimSpace(
fmt.Sprintf(`Query authorization grants granted by granter.
Examples:
$ %s q %s granter-grants cosmos1skj..
$ %s q %s grants-by-granter cosmos1skj..
`,
version.AppName, authz.ModuleName),
),
Expand Down Expand Up @@ -144,13 +144,13 @@ $ %s q %s granter-grants cosmos1skj..

func GetQueryGranteeGrants() *cobra.Command {
cmd := &cobra.Command{
Use: "grantee-grants [grantee-addr]",
Use: "grants-by-grantee [grantee-addr]",
Args: cobra.ExactArgs(1),
Short: "query authorization grants granted to a grantee",
Long: strings.TrimSpace(
fmt.Sprintf(`Query authorization grants granted to a grantee.
Examples:
$ %s q %s grantee-grants cosmos1skj..
$ %s q %s grants-by-grantee cosmos1skj..
`,
version.AppName, authz.ModuleName),
),
Expand Down
4 changes: 2 additions & 2 deletions x/feegrant/client/cli/query.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ $ %s query feegrant grant [granter] [grantee]
// GetCmdQueryFeeGrantsByGrantee returns cmd to query for all grants for a grantee.
func GetCmdQueryFeeGrantsByGrantee() *cobra.Command {
cmd := &cobra.Command{
Use: "grants [grantee]",
Use: "grantee-grants [grantee]",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about the following

Suggested change
Use: "grantee-grants [grantee]",
Use: "grants-by-grantee [grantee]",

Args: cobra.ExactArgs(1),
Short: "Query all grants of a grantee",
Long: strings.TrimSpace(
Expand Down Expand Up @@ -133,7 +133,7 @@ $ %s query feegrant grants [grantee]
// GetCmdQueryFeeGrantsByGranter returns cmd to query for all grants by a granter.
func GetCmdQueryFeeGrantsByGranter() *cobra.Command {
cmd := &cobra.Command{
Use: "grants [granter]",
Use: "granter-grants [granter]",
Args: cobra.ExactArgs(1),
Short: "Query all grants by a granter",
Long: strings.TrimSpace(
Expand Down