-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: index ante events for failed tx #12013
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
commented
May 23, 2022
yihuang
changed the title
index ante events for failed tx
fix: index ante events for failed tx
May 23, 2022
Codecov Report
@@ Coverage Diff @@
## main #12013 +/- ##
=======================================
Coverage 65.97% 65.97%
=======================================
Files 671 671
Lines 70959 70959
=======================================
+ Hits 46815 46816 +1
+ Misses 21490 21488 -2
- Partials 2654 2655 +1
|
11 tasks
Co-authored-by: yihuang <huang@crypto.com>
alexanderbez
approved these changes
May 23, 2022
alexanderbez
added
the
A:automerge
Automatically merge PR once all prerequisites pass.
label
May 23, 2022
19 tasks
alexanderbez
pushed a commit
that referenced
this pull request
May 23, 2022
randy75828
pushed a commit
to Switcheo/cosmos-sdk
that referenced
this pull request
Aug 10, 2022
Eengineer1
pushed a commit
to cheqd/cosmos-sdk
that referenced
this pull request
Aug 26, 2022
19 tasks
JeancarloBarrios
pushed a commit
to agoric-labs/cosmos-sdk
that referenced
this pull request
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the ante events for failed tx are not indexed at all, but ethermint need to rely on them to find some failed txs in json-rpc apis.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change