Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add base account getter #12154

Merged
merged 3 commits into from
Jun 6, 2022
Merged

fix: add base account getter #12154

merged 3 commits into from
Jun 6, 2022

Conversation

mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Jun 5, 2022

expected work:

cronosd tx vesting create-vesting-account crc13l5jnsydy3z5wevegpkmyechc0qvpjc2thwedr 1000000basetcro 1654325260092 --from=validator --keyring-backend=test --chain-id=cronos_777-1 --fees=2000000basetcro --home=$CHOME --broadcast-mode block
{"body":{"messages":[{"@type":"/cosmos.vesting.v1beta1.MsgCreateVestingAccount","from_address":"crc18z6q38mhvtsvyr5mak8fj8s8g4gw7kjjtsgrn7","to_address":"crc13l5jnsydy3z5wevegpkmyechc0qvpjc2thwedr","amount":[{"denom":"basetcro","amount":"1000000"}],"end_time":"1654325260092","delayed":false}],"memo":"","timeout_height":"0","extension_options":[],"non_critical_extension_options":[]},"auth_info":{"signer_infos":[],"fee":{"amount":[{"denom":"basetcro","amount":"2000000"}],"gas_limit":"200000","payer":"","granter":""}},"signatures":[]}

confirm transaction before signing and broadcasting [y/N]: y
{"height":"27","txhash":"4CBA93C22D0963A7DFF8E4F4C749D97A08FC254EB74D8E803A850F050A1148F9","codespace":"","code":0,"data":"0A310A2F2F636F736D6F732E76657374696E672E763162657461312E4D736743726561746556657374696E674163636F756E74","raw_log":"[{\"events\":[{\"type\":\"coin_received\",\"attributes\":[{\"key\":\"receiver\",\"value\":\"crc13l5jnsydy3z5wevegpkmyechc0qvpjc2thwedr\"},{\"key\":\"amount\",\"value\":\"1000000basetcro\"}]},{\"type\":\"coin_spent\",\"attributes\":[{\"key\":\"spender\",\"value\":\"crc18z6q38mhvtsvyr5mak8fj8s8g4gw7kjjtsgrn7\"},{\"key\":\"amount\",\"value\":\"1000000basetcro\"}]},{\"type\":\"message\",\"attributes\":[{\"key\":\"action\",\"value\":\"/cosmos.vesting.v1beta1.MsgCreateVestingAccount\"},{\"key\":\"sender\",\"value\":\"crc18z6q38mhvtsvyr5mak8fj8s8g4gw7kjjtsgrn7\"},{\"key\":\"module\",\"value\":\"vesting\"}]},{\"type\":\"transfer\",\"attributes\":[{\"key\":\"recipient\",\"value\":\"crc13l5jnsydy3z5wevegpkmyechc0qvpjc2thwedr\"},{\"key\":\"sender\",\"value\":\"crc18z6q38mhvtsvyr5mak8fj8s8g4gw7kjjtsgrn7\"},{\"key\":\"amount\",\"value\":\"1000000basetcro\"}]}]}]","logs":[{"msg_index":0,"log":"","events":[{"type":"coin_received","attributes":[{"key":"receiver","value":"crc13l5jnsydy3z5wevegpkmyechc0qvpjc2thwedr"},{"key":"amount","value":"1000000basetcro"}]},{"type":"coin_spent","attributes":[{"key":"spender","value":"crc18z6q38mhvtsvyr5mak8fj8s8g4gw7kjjtsgrn7"},{"key":"amount","value":"1000000basetcro"}]},{"type":"message","attributes":[{"key":"action","value":"/cosmos.vesting.v1beta1.MsgCreateVestingAccount"},{"key":"sender","value":"crc18z6q38mhvtsvyr5mak8fj8s8g4gw7kjjtsgrn7"},{"key":"module","value":"vesting"}]},{"type":"transfer","attributes":[{"key":"recipient","value":"crc13l5jnsydy3z5wevegpkmyechc0qvpjc2thwedr"},{"key":"sender","value":"crc18z6q38mhvtsvyr5mak8fj8s8g4gw7kjjtsgrn7"},{"key":"amount","value":"1000000basetcro"}]}]}],"info":"","gas_wanted":"200000","gas_used":"104425","tx":null,"timestamp":"","events":[{"type":"coin_spent","attributes":[{"key":"c3BlbmRlcg==","value":"Y3JjMTh6NnEzOG1odnRzdnlyNW1hazhmajhzOGc0Z3c3a2pqdHNncm43","index":true},{"key":"YW1vdW50","value":"MjAwMDAwMGJhc2V0Y3Jv","index":true}]},{"type":"coin_received","attributes":[{"key":"cmVjZWl2ZXI=","value":"Y3JjMTd4cGZ2YWttMmFtZzk2MnlsczZmODR6M2tlbGw4YzVsODhla2Vy","index":true},{"key":"YW1vdW50","value":"MjAwMDAwMGJhc2V0Y3Jv","index":true}]},{"type":"transfer","attributes":[{"key":"cmVjaXBpZW50","value":"Y3JjMTd4cGZ2YWttMmFtZzk2MnlsczZmODR6M2tlbGw4YzVsODhla2Vy","index":true},{"key":"c2VuZGVy","value":"Y3JjMTh6NnEzOG1odnRzdnlyNW1hazhmajhzOGc0Z3c3a2pqdHNncm43","index":true},{"key":"YW1vdW50","value":"MjAwMDAwMGJhc2V0Y3Jv","index":true}]},{"type":"message","attributes":[{"key":"c2VuZGVy","value":"Y3JjMTh6NnEzOG1odnRzdnlyNW1hazhmajhzOGc0Z3c3a2pqdHNncm43","index":true}]},{"type":"tx","attributes":[{"key":"ZmVl","value":"MjAwMDAwMGJhc2V0Y3Jv","index":true}]},{"type":"tx","attributes":[{"key":"YWNjX3NlcQ==","value":"Y3JjMTh6NnEzOG1odnRzdnlyNW1hazhmajhzOGc0Z3c3a2pqdHNncm43LzE=","index":true}]},{"type":"tx","attributes":[{"key":"c2lnbmF0dXJl","value":"S1NJRUNMaTBya09yUGowTXR3NU12RkVzaGVOWmJjYlVnZTEwaGVmYnJaSmlFd3UxUHNlOXd4Tmt0R3BrV0dmVW16S3RMdjhIb0hsNzI0ZUJ1NHhtZ2dFPQ==","index":true}]},{"type":"message","attributes":[{"key":"YWN0aW9u","value":"L2Nvc21vcy52ZXN0aW5nLnYxYmV0YTEuTXNnQ3JlYXRlVmVzdGluZ0FjY291bnQ=","index":true}]},{"type":"coin_spent","attributes":[{"key":"c3BlbmRlcg==","value":"Y3JjMTh6NnEzOG1odnRzdnlyNW1hazhmajhzOGc0Z3c3a2pqdHNncm43","index":true},{"key":"YW1vdW50","value":"MTAwMDAwMGJhc2V0Y3Jv","index":true}]},{"type":"coin_received","attributes":[{"key":"cmVjZWl2ZXI=","value":"Y3JjMTNsNWpuc3lkeTN6NXdldmVncGtteWVjaGMwcXZwamMydGh3ZWRy","index":true},{"key":"YW1vdW50","value":"MTAwMDAwMGJhc2V0Y3Jv","index":true}]},{"type":"transfer","attributes":[{"key":"cmVjaXBpZW50","value":"Y3JjMTNsNWpuc3lkeTN6NXdldmVncGtteWVjaGMwcXZwamMydGh3ZWRy","index":true},{"key":"c2VuZGVy","value":"Y3JjMTh6NnEzOG1odnRzdnlyNW1hazhmajhzOGc0Z3c3a2pqdHNncm43","index":true},{"key":"YW1vdW50","value":"MTAwMDAwMGJhc2V0Y3Jv","index":true}]},{"type":"message","attributes":[{"key":"c2VuZGVy","value":"Y3JjMTh6NnEzOG1odnRzdnlyNW1hazhmajhzOGc0Z3c3a2pqdHNncm43","index":true}]},{"type":"message","attributes":[{"key":"bW9kdWxl","value":"dmVzdGluZw==","index":true}]}]}

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@mmsqe mmsqe requested a review from a team as a code owner June 5, 2022 13:16
@mmsqe mmsqe changed the title add base account getter fix: add base account getter Jun 5, 2022
@alexanderbez alexanderbez added backport/0.45.x backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release labels Jun 6, 2022
@alexanderbez
Copy link
Contributor

@mmsqe prior to merging this, can you please add a quick changelog entry 🙏

@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #12154 (ec1e4bf) into main (544afb6) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12154      +/-   ##
==========================================
- Coverage   66.01%   65.98%   -0.03%     
==========================================
  Files         672      672              
  Lines       71053    71053              
==========================================
- Hits        46905    46887      -18     
- Misses      21485    21503      +18     
  Partials     2663     2663              
Impacted Files Coverage Δ
x/distribution/simulation/operations.go 80.21% <0.00%> (-9.90%) ⬇️
crypto/keys/internal/ecdsa/privkey.go 81.13% <0.00%> (-1.89%) ⬇️
x/group/keeper/keeper.go 54.85% <0.00%> (+0.42%) ⬆️

@alexanderbez alexanderbez merged commit a39be7b into cosmos:main Jun 6, 2022
mergify bot pushed a commit that referenced this pull request Jun 6, 2022
mergify bot pushed a commit that referenced this pull request Jun 6, 2022
(cherry picked from commit a39be7b)

# Conflicts:
#	CHANGELOG.md
tac0turtle pushed a commit that referenced this pull request Jun 6, 2022
* fix: add base account getter (#12154)

(cherry picked from commit a39be7b)

# Conflicts:
#	CHANGELOG.md

* fix conflict

Co-authored-by: mmsqe <tqd0800210105@gmail.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
alexanderbez added a commit that referenced this pull request Jun 9, 2022
@mmsqe mmsqe deleted the add-base-account-getter branch June 27, 2022 10:10
randy75828 pushed a commit to Switcheo/cosmos-sdk that referenced this pull request Aug 10, 2022
* fix: add base account getter (cosmos#12154)

(cherry picked from commit a39be7b)

# Conflicts:
#	CHANGELOG.md

* fix conflict

Co-authored-by: mmsqe <tqd0800210105@gmail.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
randy75828 pushed a commit to Switcheo/cosmos-sdk that referenced this pull request Aug 10, 2022
Eengineer1 pushed a commit to cheqd/cosmos-sdk that referenced this pull request Aug 26, 2022
* fix: add base account getter (cosmos#12154)

(cherry picked from commit a39be7b)

* fix conflict

Co-authored-by: mmsqe <tqd0800210105@gmail.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024
* fix: add base account getter (cosmos#12154)

(cherry picked from commit a39be7b)

# Conflicts:
#	CHANGELOG.md

* fix conflict

Co-authored-by: mmsqe <tqd0800210105@gmail.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release C:x/auth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants