Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix MsgExec not verifying the validity of nested messages #12184

Merged
merged 4 commits into from
Jun 8, 2022
Merged

fix: Fix MsgExec not verifying the validity of nested messages #12184

merged 4 commits into from
Jun 8, 2022

Conversation

bruce-wayne2
Copy link
Contributor

Description

Fix MsgExec not verifying the validity of nested messages.

Maybe it's a security issue?


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I don't think this is a security issue as the validate basic is a stateless change, but the state transition would of failed.

@alexanderbez alexanderbez merged commit 64409bf into cosmos:main Jun 8, 2022
javiersuweijie pushed a commit to terra-money/cosmos-sdk that referenced this pull request Jun 27, 2023
javiersuweijie added a commit to terra-money/cosmos-sdk that referenced this pull request Jun 27, 2023
fix: Fix MsgExec not verifying the validity of nested messages (cosmos#12184)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants