feat(cli): add acc-address by id cli and grpc gateway api #12199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
gsk967
changed the title
likhita-809
reviewed
Jun 9, 2022
likhita-809
reviewed
Jun 9, 2022
likhita-809
reviewed
Jun 9, 2022
likhita-809
reviewed
Jun 9, 2022
likhita-809
reviewed
Jun 9, 2022
likhita-809
reviewed
Jun 9, 2022
alexanderbez
reviewed
Jun 9, 2022
1. Removed conv from str to bytes and bytes to string
|
@gsk967 can you look into the failing tests? |
alexanderbez
approved these changes
Jun 14, 2022
|
@alexanderbez @likhita-809 add state migration test cases , Please look into changes. |
x/auth/keeper/migrations.go
Outdated
| } | ||
|
|
||
| // V45_SetAccount implements V45_SetAccount | ||
| // set the account without map to accAddr to accNumber |
There was a problem hiding this comment.
Suggested change
| // set the account without map to accAddr to accNumber | |
| // set the account without map to accAddr to accNumber. | |
| // | |
| // NOTE: This is used for testing purposes only. |
alexanderbez
approved these changes
Jun 15, 2022
alexanderbez
added
the
backport/0.46.x
mergify bot
pushed a commit
that referenced
this pull request
Jun 15, 2022
(cherry picked from commit 4385325)
alexanderbez
pushed a commit
that referenced
this pull request
Jun 16, 2022
amaury1093
reviewed
Oct 5, 2022
| @@ -24,6 +24,11 @@ service Query { | |||
| option (google.api.http).get = "/cosmos/auth/v1beta1/accounts/{address}"; | |||
| } | |||
|
|
|||
| // AccountAddressByID returns account address based on account id | |||
| rpc AccountAddressByID(QueryAccountAddressByIDRequest) returns (QueryAccountAddressByIDResponse) { | |||
There was a problem hiding this comment.
AccountAddressByID seems like a weird name to me. Do people use the term "ID"?
I would call it AddressByAccountNumber or AddressByAccNum
|
|
||
| // QueryAccountAddressByIDRequest is the request type for AccountAddressByID rpc method | ||
| message QueryAccountAddressByIDRequest{ | ||
| int64 id = 1; |
There was a problem hiding this comment.
why is this int64, when account_number is uint64 everywhere?
| @@ -24,6 +24,11 @@ service Query { | |||
| option (google.api.http).get = "/cosmos/auth/v1beta1/accounts/{address}"; | |||
| } | |||
|
|
|||
| // AccountAddressByID returns account address based on account id | |||
There was a problem hiding this comment.
This is missing a Since proto comment
|
|
||
| // QueryAccountAddressByIDResponse is the response type for AccountAddressByID rpc method | ||
| message QueryAccountAddressByIDResponse { | ||
| string account_address = 1 [(cosmos_proto.scalar) = "cosmos.AddressString"]; |
There was a problem hiding this comment.
Would rename this field to address simply, which makes it consistent with some other places
|
If we can't rename the proto fields (too late), then we can at least update the CLI command name and gRPC routes. |
JeancarloBarrios
pushed a commit
to agoric-labs/cosmos-sdk
that referenced
this pull request
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #12155
This pull request contains the address-by-id cli cmd and grpc gateway api request for account address retrieval by id
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change