bash testing cleanup #122
Merged
bash testing cleanup #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanfrey
approved these changes
Jun 21, 2017
| # XXX Ex Usage: quickTearDown | ||
| # Desc: close the test server, use with shunit2 OneTimeTearDown() | ||
| quickTearDown() { | ||
| printf "\n\nstopping $SERVER_EXE test server..." |
There was a problem hiding this comment.
Wondering why printf over echo, but saw some links.... guess I need to update all the scripts now... (or maybe you did ;)
| @@ -46,7 +84,10 @@ initServer() { | |||
| fi | |||
| } | |||
|
|
|||
| # initClient requires chain_id arg, port is optional (default 46657) | |||
| # XXX Ex Usage1: initClient $CHAINID | |||
There was a problem hiding this comment.
I like the XXX example header. 👍
|
|
||
| # XXX Ex Usage: quickSetup $WORK_NAME $CHAIN_ID | ||
| # Desc: Start the program, use with shunit2 OneTimeSetUp() | ||
| quickSetup() { |
There was a problem hiding this comment.
Totally nice to refactor out. Good call.
tests/cli/counter.sh
Outdated
| @@ -75,8 +51,8 @@ test02GetCounter() { | |||
| assertFalse "no default count" $? | |||
| } | |||
|
|
|||
| # checkAccount $COUNT $BALANCE | |||
| # assumes just one coin, checks the balance of first coin in any case | |||
| # CheckAccount $COUNT $BALANCE | |||
There was a problem hiding this comment.
Uh... it was lower case due to the function name. Also wrong function. I'll fix it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #118