Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(depinject): clarify depinject API #12214

Merged
merged 4 commits into from
Jul 19, 2022
Merged

Conversation

kocubinski
Copy link
Member

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@kocubinski kocubinski changed the title Update README for depinject docs(depinject): README Jun 9, 2022
@julienrbrt julienrbrt changed the base branch from main to epic/app-wiring June 29, 2022 13:43
@julienrbrt julienrbrt changed the base branch from epic/app-wiring to main June 29, 2022 15:41
depinject/README.md Outdated Show resolved Hide resolved
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we merge this as is?

@julienrbrt julienrbrt changed the title docs(depinject): README docs(depinject): clarify depinject API Jul 19, 2022
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kocubinski kocubinski marked this pull request as ready for review July 19, 2022 13:56
@kocubinski kocubinski requested a review from a team as a code owner July 19, 2022 13:56
@julienrbrt
Copy link
Member

Merging.. we should update this when we create "An introduction to depinject" tutorial on docs.cosmos.network.

@julienrbrt julienrbrt merged commit 467d72b into main Jul 19, 2022
@julienrbrt julienrbrt deleted the kocubinski/depinject-docs branch July 19, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants