Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove proto breakage check action on main #12304

Merged
merged 2 commits into from
Jun 20, 2022
Merged

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Jun 20, 2022

Description

This GH action always fails on main, while passing on the pull requests: https://github.com/cosmos/cosmos-sdk/actions/workflows/proto.yml
This is an attempt to fix that.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner June 20, 2022 13:52
@tac0turtle
Copy link
Member

hmm seems like someone added it to run on push to main, if we remove that it should all work. this doesn't need to run on main anyways

@julienrbrt julienrbrt changed the title ci: fix github action proto breakage check on main ci: do not proto breakage check action on main Jun 20, 2022
@julienrbrt julienrbrt changed the title ci: do not proto breakage check action on main ci: remove proto breakage check action on main Jun 20, 2022
@tac0turtle tac0turtle merged commit f14e9eb into main Jun 20, 2022
@tac0turtle tac0turtle deleted the julien/gh-ci-proto branch June 20, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants