Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(telemetry): start telemetry independently from the API server #12448

Merged
merged 7 commits into from
Jul 7, 2022

Conversation

robert-zaremba
Copy link
Collaborator

@robert-zaremba robert-zaremba commented Jul 5, 2022

Description

Closes: #12447

  • initializes telemetry in both stand alone mode (without tendermint) and in-process mode.
  • starts telemetry independently from the API server

Follow ups


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@robert-zaremba robert-zaremba marked this pull request as ready for review July 5, 2022 13:12
@robert-zaremba robert-zaremba requested a review from a team as a code owner July 5, 2022 13:12
@robert-zaremba robert-zaremba added backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release A:automerge Automatically merge PR once all prerequisites pass. labels Jul 5, 2022
@robert-zaremba
Copy link
Collaborator Author

Adding backport-46 label. If you don't agree then feel free to drop it.

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
@robert-zaremba robert-zaremba removed the A:automerge Automatically merge PR once all prerequisites pass. label Jul 7, 2022
server/start.go Fixed Show fixed Hide fixed
@robert-zaremba
Copy link
Collaborator Author

After checking back and forth, it fails due to: #12439

@robert-zaremba
Copy link
Collaborator Author

x/auth/client and client/grpc/tmservice are sometimes passing.

@robert-zaremba robert-zaremba added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 7, 2022
@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #12448 (88047b4) into main (18da0e9) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 88047b4 differs from pull request most recent head 74a1196. Consider uploading reports for the commit 74a1196 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12448      +/-   ##
==========================================
+ Coverage   65.59%   65.62%   +0.02%     
==========================================
  Files         685      685              
  Lines       71635    71635              
==========================================
+ Hits        46990    47007      +17     
+ Misses      21999    21981      -18     
- Partials     2646     2647       +1     
Impacted Files Coverage Δ
crypto/keys/internal/ecdsa/privkey.go 81.13% <0.00%> (-1.89%) ⬇️
x/auth/tx/service.go 72.18% <0.00%> (ø)
x/distribution/simulation/operations.go 90.42% <0.00%> (+9.57%) ⬆️

@robert-zaremba robert-zaremba merged commit 9057db6 into main Jul 7, 2022
@robert-zaremba robert-zaremba deleted the robert/telemetry branch July 7, 2022 17:41
mergify bot pushed a commit that referenced this pull request Jul 7, 2022
…2448)

* fix(telemetry): start telemetry independently from the API server

* fix unlock

* add changelog

* Update CHANGELOG.md

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
(cherry picked from commit 9057db6)

# Conflicts:
#	CHANGELOG.md
yihuang added a commit to yihuang/ethermint that referenced this pull request Jan 19, 2023
JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Telemetry should be working even when the api server is disabled.
2 participants