Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support providing custom keyring for keystore. #12453

Merged
merged 10 commits into from
Jul 8, 2022
Merged

feat: Support providing custom keyring for keystore. #12453

merged 10 commits into from
Jul 8, 2022

Conversation

chatton
Copy link
Contributor

@chatton chatton commented Jul 5, 2022

Description

Closes: #12438


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@chatton chatton changed the title feat: Support providing custom keyring for keystore. improvement: Support providing custom keyring for keystore. Jul 5, 2022
@chatton chatton changed the title improvement: Support providing custom keyring for keystore. feat: Support providing custom keyring for keystore. Jul 5, 2022
@alexanderbez
Copy link
Contributor

@aaronc does this have any conflicts with the keystone project/replacement of keyring?

@jackzampolin
Copy link
Member

No this just adds the ability to easily instantiate an in memory keyring to the existing code.

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, is this R4R?

@chatton chatton marked this pull request as ready for review July 6, 2022 08:14
@chatton chatton requested a review from a team as a code owner July 6, 2022 08:14
@chatton
Copy link
Contributor Author

chatton commented Jul 6, 2022

Hi @AmauryM, it's ready now, I was just waiting for CI to pass

@alexanderbez alexanderbez added A:automerge Automatically merge PR once all prerequisites pass. backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release labels Jul 6, 2022
@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #12453 (603e2f3) into main (fd7cdd6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #12453   +/-   ##
=======================================
  Coverage   65.57%   65.57%           
=======================================
  Files         685      685           
  Lines       71634    71636    +2     
=======================================
+ Hits        46974    46976    +2     
  Misses      22013    22013           
  Partials     2647     2647           
Impacted Files Coverage Δ
crypto/keyring/keyring.go 61.95% <100.00%> (+0.12%) ⬆️

@mergify mergify bot merged commit 0bf3098 into cosmos:main Jul 8, 2022
mergify bot pushed a commit that referenced this pull request Jul 8, 2022
## Description

Closes: #12438

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [X] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [X] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [x] added a changelog entry to `CHANGELOG.md`
- [x] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [x] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)

(cherry picked from commit 0bf3098)

# Conflicts:
#	CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for creation of keystore instances with arbitrary keyring implementations
5 participants