Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: panic string in staking/val_state_change.go::UnbondingToUnbonded #12566

Merged
merged 4 commits into from
Jul 13, 2022
Merged

fix: panic string in staking/val_state_change.go::UnbondingToUnbonded #12566

merged 4 commits into from
Jul 13, 2022

Conversation

danwt
Copy link
Contributor

@danwt danwt commented Jul 13, 2022

Fix panic string in staking/val_state_change.go::UnbondingToUnbonded

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Fix panic string in staking/val_state_change.go::UnbondingToUnbonded
@danwt danwt requested a review from a team as a code owner July 13, 2022 17:08
@facundomedica facundomedica changed the title Fix panic string in staking/val_state_change.go::UnbondingToUnbonded Fix: panic string in staking/val_state_change.go::UnbondingToUnbonded Jul 13, 2022
@facundomedica facundomedica changed the title Fix: panic string in staking/val_state_change.go::UnbondingToUnbonded fix: panic string in staking/val_state_change.go::UnbondingToUnbonded Jul 13, 2022
@julienrbrt julienrbrt added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 13, 2022
@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #12566 (a170a5e) into main (9c24a58) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12566      +/-   ##
==========================================
- Coverage   65.20%   65.20%   -0.01%     
==========================================
  Files         694      694              
  Lines       71855    71855              
==========================================
- Hits        46853    46851       -2     
- Misses      22371    22374       +3     
+ Partials     2631     2630       -1     
Impacted Files Coverage Δ
x/staking/keeper/val_state_change.go 64.77% <0.00%> (ø)
crypto/keys/internal/ecdsa/privkey.go 81.13% <0.00%> (-1.89%) ⬇️
x/group/keeper/keeper.go 58.26% <0.00%> (-0.40%) ⬇️

@mergify mergify bot merged commit da7f046 into cosmos:main Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/staking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants