fix: MsgMultiSend validation allows only a single sender #12610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ita/fix-multisend-vaidatebasic
Codecov Report
@@ Coverage Diff @@
## main #12610 +/- ##
==========================================
+ Coverage 65.22% 65.27% +0.04%
==========================================
Files 693 697 +4
Lines 71843 72075 +232
==========================================
+ Hits 46863 47045 +182
- Misses 22349 22386 +37
- Partials 2631 2644 +13
|
likhita-809
requested review from
ValarDragon,
alexanderbez,
amaury1093,
anilcse,
atheeshp,
JeancarloBarrios,
julienrbrt and
tac0turtle
amaury1093
reviewed
Jul 18, 2022
…ita/fix-multisend-vaidatebasic
julienrbrt
reviewed
Jul 19, 2022
julienrbrt
approved these changes
Jul 19, 2022
| @@ -56,6 +56,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ | |||
|
|
|||
| ### State Machine Breaking | |||
|
|
|||
| * (x/bank) [#12610](https://github.com/cosmos/cosmos-sdk/pull/12610) `MsgMultiSend` now allows only a single input. | |||
There was a problem hiding this comment.
TODO: Add in UPGRADING.md the alternative. (For me to remember for next version)
amaury1093
reviewed
Jul 20, 2022
|
|
||
| option (gogoproto.equal) = false; | ||
|
|
||
| repeated Input inputs = 1 [(gogoproto.nullable) = false]; | ||
| Input input = 1 [(gogoproto.nullable) = false]; |
There was a problem hiding this comment.
This PR got merged with a proto breaking change, and the proto package did not get bumped.
We should actually revert this change. @likhita-809 could you create a follow-up PR?
There was a problem hiding this comment.
(thinking about it, my comment #12610 (comment) might have been confusing... I thought there was something to change in the signer proto option, but there's actually nothing to change).
There was a problem hiding this comment.
So, should I revert it to this commit abc4340#diff-4b06aeb8c7fd43a99b1a1c0eb62792aae06649ead661bd26bc843e9a0485336a
There was a problem hiding this comment.
Not 100% sure which commit it should be, but all the proto changes in this PR should be reverted.
likhita-809
added a commit
that referenced
this pull request
Jul 21, 2022
19 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jul 21, 2022
## Description ref:#12610 (comment) --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
4 tasks
19 tasks
This was referenced Mar 6, 2023
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #12601
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change