-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Move sdk.Dec to math package #12634
Conversation
math/CHANGELOG.md
Outdated
@@ -30,3 +30,5 @@ Ref: https://keepachangelog.com/en/1.0.0/ | |||
# Changelog | |||
|
|||
## [Unreleased] | |||
|
|||
* [#12634](https://github.com/cosmos/cosmos-sdk/pull/12634) Move `sdk.Dec` to math package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add this same entry in the root changelog as well?
massively appreciated change. Thanks @AmauryM ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we call this math.LegacyDec
please? (Keeping aliases as sdk.Dec
is still fine). And also start merging the GDA/apd code so we get that done for once and for all (ref #11783)?
The code I'm referring to is this code: https://github.com/regen-network/regen-ledger/blob/master/types/math/dec.go. We've had it tested and in use for a while - the main difference is this Dec
returns errors rather than panicking which I think is good.
I did this in 7304e08. TBH I'm not convinced. The API looks ugly with One advantage of having versioned go modules is that we could stop calling stuff legacy, right? I'm more in favor or keeping it in v1. |
Description
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change