-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: make simapp.MakeTestEncodingConfig
private
#12747
Conversation
simapp.MakeTestEncodingConfig
privatesimapp.MakeTestEncodingConfig
private
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one question.
) | ||
|
||
func Test_TestnetCmd(t *testing.T) { | ||
home := t.TempDir() | ||
encodingConfig := simapp.MakeTestEncodingConfig() | ||
encodingConfig := moduletestutil.MakeTestEncodingConfig(staking.AppModuleBasic{}, auth.AppModuleBasic{}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the logic for only needing staking and auth AppModuleBasic here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- We marshal the genesis in
initGenFiles
so we need auth (https://github.com/cosmos/cosmos-sdk/blob/main/simapp/simd/cmd/testnet.go#L370) - Then here we need
staking
for the validator msg created there. Otherwise, we getunable to resolve type URL /cosmos.staking.v1beta1.MsgCreateValidator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this @julienrbrt 🙌
* feat: make `simapp.MakeTestEncodingConfig` private * fix legacy build * update changelog and upgrading.md * updates docs
Description
Ref: #11899. Closes #7642
Makes
simapp.MakeTestEncodingConfig
private and usemoduletestutil.MakeTestEncodingConfig(...)
in tests.TODO
docs/run-node/txs.md
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change