Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update make format #12892

Merged
merged 4 commits into from
Aug 10, 2022
Merged

chore: update make format #12892

merged 4 commits into from
Aug 10, 2022

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Aug 10, 2022

Description

This PR updates make format so that:

  • gofumpt is run
  • golangci-lint run ./... --fix is run
  • the correct files are excluded from formatting changes

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@faddat faddat requested a review from a team as a code owner August 10, 2022 15:55
@alexanderbez alexanderbez changed the title update make format chore: update make format Aug 10, 2022
@julienrbrt
Copy link
Member

julienrbrt commented Aug 10, 2022

Have you applied that to the codebase? I would have expected more changes. Or this PR only updates the command but does not run it?

EDIT: Just noticed :) #12867 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants