Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix linting issues exposed by fixing golangci-lint #12895

Merged
merged 4 commits into from
Aug 11, 2022

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Aug 10, 2022

This PR fixes linting issues that were exposed by fixing golangci-lint

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #12895 (c74fee6) into main (15b04c2) will increase coverage by 2.21%.
The diff coverage is 71.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12895      +/-   ##
==========================================
+ Coverage   55.87%   58.09%   +2.21%     
==========================================
  Files         650      734      +84     
  Lines       55008    62695    +7687     
==========================================
+ Hits        30737    36424    +5687     
- Misses      21807    23302    +1495     
- Partials     2464     2969     +505     
Impacted Files Coverage Δ
baseapp/baseapp.go 76.87% <ø> (ø)
baseapp/msg_service_router.go 80.88% <ø> (ø)
client/keys/add.go 63.34% <ø> (ø)
codec/amino_codec.go 100.00% <ø> (ø)
codec/proto_codec.go 61.31% <ø> (ø)
crypto/hd/hdpath.go 98.40% <ø> (ø)
crypto/keys/multisig/codec.go 100.00% <ø> (ø)
crypto/keys/secp256k1/secp256k1.go 88.63% <ø> (ø)
crypto/keys/secp256k1/secp256k1_nocgo.go 83.33% <ø> (ø)
depinject/config.go 85.88% <ø> (ø)
... and 176 more

@tac0turtle tac0turtle changed the title fix linting issues exposed by fixing golangci-lint chore: fix linting issues exposed by fixing golangci-lint Aug 11, 2022
@julienrbrt julienrbrt merged commit 0943a70 into cosmos:main Aug 11, 2022
@julienrbrt
Copy link
Member

Thanks @faddat!

larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants