Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update all dependencies for all go mod with dependabot #13180

Merged
merged 13 commits into from
Sep 14, 2022

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Sep 7, 2022

Description

Closes #11409

The number of go modules is increasing and will keep increasing.
This PR automates the update of all go modules when dependabot submits a PR (so that we don't need to run CI fifteen times, for each dependency update).
We use the already existing script go-update-dep-all.sh for updating all go modules.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner September 7, 2022 19:59
@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #13180 (7a467e0) into main (4fe7797) will decrease coverage by 2.28%.
The diff coverage is 41.71%.

❗ Current head 7a467e0 differs from pull request most recent head d8a979e. Consider uploading reports for the commit d8a979e to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13180      +/-   ##
==========================================
- Coverage   55.87%   53.59%   -2.29%     
==========================================
  Files         646      644       -2     
  Lines       54895    55136     +241     
==========================================
- Hits        30675    29552    -1123     
- Misses      21762    23212    +1450     
+ Partials     2458     2372      -86     
Impacted Files Coverage Δ
baseapp/abci.go 67.01% <0.00%> (+2.59%) ⬆️
baseapp/baseapp.go 77.93% <ø> (+1.06%) ⬆️
baseapp/options.go 69.23% <ø> (+0.71%) ⬆️
client/cmd.go 57.73% <0.00%> (ø)
client/context.go 54.49% <0.00%> (-1.79%) ⬇️
client/flags/flags.go 19.35% <0.00%> (-0.32%) ⬇️
client/rpc/status.go 66.66% <ø> (ø)
client/utils.go 34.92% <0.00%> (ø)
crypto/keys/secp256k1/secp256k1.go 88.63% <ø> (ø)
server/config/config.go 38.00% <0.00%> (-1.59%) ⬇️
... and 160 more

@julienrbrt julienrbrt marked this pull request as draft September 7, 2022 20:30
@mergify mergify bot mentioned this pull request Sep 7, 2022
19 tasks
@julienrbrt julienrbrt marked this pull request as ready for review September 8, 2022 00:34
@julienrbrt julienrbrt marked this pull request as draft September 8, 2022 00:48
@julienrbrt julienrbrt marked this pull request as ready for review September 10, 2022 00:26
@julienrbrt
Copy link
Member Author

julienrbrt commented Sep 10, 2022

Check-out https://github.com/julienrbrt/cosmos-sdk/pull/4 to see it in action.

@julienrbrt julienrbrt force-pushed the julien/automate-dependabot branch from 0ea68ba to 75a6854 Compare September 10, 2022 00:32
@julienrbrt julienrbrt force-pushed the julien/automate-dependabot branch from f4a732e to df826c9 Compare September 10, 2022 00:37
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@julienrbrt julienrbrt merged commit 9dacaa4 into main Sep 14, 2022
@julienrbrt julienrbrt deleted the julien/automate-dependabot branch September 14, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group dependabot updates for same deps in one PR
4 participants