Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove newly introduced simapp dependency #13219

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

julienrbrt
Copy link
Member

Description

#11981 introduced a simapp dependency to the SDK, which we don't want.
This PR fixes that and https://github.com/cosmos/cosmos-sdk/actions/workflows/dependencies-review.yml should be required before a merge for avoiding regression.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner September 9, 2022 10:22
@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #13219 (a3ea60c) into main (1bccc54) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13219      +/-   ##
==========================================
- Coverage   53.65%   53.64%   -0.02%     
==========================================
  Files         647      647              
  Lines       55253    55253              
==========================================
- Hits        29647    29638       -9     
- Misses      23234    23241       +7     
- Partials     2372     2374       +2     
Impacted Files Coverage Δ
x/bank/module.go 60.78% <0.00%> (-8.83%) ⬇️
crypto/keys/internal/ecdsa/privkey.go 81.13% <0.00%> (-1.89%) ⬇️
x/group/keeper/keeper.go 56.64% <0.00%> (+0.39%) ⬆️

@julienrbrt julienrbrt enabled auto-merge (squash) September 9, 2022 10:42
@julienrbrt julienrbrt merged commit 5912f75 into main Sep 9, 2022
@julienrbrt julienrbrt deleted the julien/remove-simapp-dependency branch September 9, 2022 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants