Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove deprecated sdk.NewLevelDB #13380

Merged
merged 3 commits into from
Sep 25, 2022
Merged

Conversation

julienrbrt
Copy link
Member

Description

Closes: #11241


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner September 24, 2022 20:45
@codecov
Copy link

codecov bot commented Sep 24, 2022

Codecov Report

Merging #13380 (bf08f48) into main (55373cb) will decrease coverage by 0.29%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13380      +/-   ##
==========================================
- Coverage   54.61%   54.32%   -0.30%     
==========================================
  Files         642      639       -3     
  Lines       55477    54600     -877     
==========================================
- Hits        30297    29659     -638     
+ Misses      22748    22559     -189     
+ Partials     2432     2382      -50     
Impacted Files Coverage Δ
types/utils.go 89.61% <ø> (+6.47%) ⬆️
math/uint.go
math/int.go
math/dec.go
x/group/keeper/keeper.go 56.64% <0.00%> (+0.39%) ⬆️
x/staking/simulation/operations.go 75.91% <0.00%> (+1.37%) ⬆️
crypto/keys/internal/ecdsa/privkey.go 83.01% <0.00%> (+1.88%) ⬆️

@julienrbrt julienrbrt enabled auto-merge (squash) September 25, 2022 09:46
@julienrbrt julienrbrt merged commit 3de5aa8 into main Sep 25, 2022
@julienrbrt julienrbrt deleted the julien/refactor-leveldb branch September 25, 2022 10:16
Wryhder pushed a commit to Wryhder/cosmos-sdk that referenced this pull request Oct 26, 2022
* refactor!: remove deprecated `sdk.NewLevelDB`

* updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated sdk.NewLevelDB
2 participants