refactor: Improve and clarify API around AccountAddressById
#13460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:Store
C:x/distribution
amaury1093
added
the
backport/0.46.x
amaury1093
changed the title
AccountAddressById AccountAddressById
julienrbrt
reviewed
Oct 6, 2022
julienrbrt
reviewed
Oct 6, 2022
julienrbrt
reviewed
Oct 6, 2022
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Julien Robert <julien@rbrt.fr>
|
No clue what is happening with CI. We had the same error for the Sims. Retrying fixes it. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ctx := sdk.UnwrapSDKContext(c) | ||
| address := ak.GetAccountAddressByID(ctx, req.Id) | ||
| address := ak.GetAccountAddressByID(ctx, uint64(req.GetId())) |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion
atheeshp
approved these changes
Oct 6, 2022
| * (types) [13430](https://github.com/cosmos/cosmos-sdk/pull/13430) Remove unused code `ResponseCheckTx` and `ResponseDeliverTx` | ||
| * (x/gov) [#13160](https://github.com/cosmos/cosmos-sdk/pull/13160) Remove custom marshaling of proposl and voteoption. | ||
| * (types) [#13430](https://github.com/cosmos/cosmos-sdk/pull/13430) Remove unused code `ResponseCheckTx` and `ResponseDeliverTx` | ||
| * (auth) [#13460](https://github.com/cosmos/cosmos-sdk/pull/13460) The `q auth address-by-id` CLI command has been renamed to `q auth address-by-acc-num` to be more explicit. However, the old `address-by-id` version is still kept as an alias, for backwards compatibility. |
There was a problem hiding this comment.
shouldn't this go under CLI Breaking Changes?
There was a problem hiding this comment.
I actually kept address-by-id as a CLI command alias, for backwards compat
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #13460 +/- ##
==========================================
- Coverage 53.89% 53.87% -0.03%
==========================================
Files 657 641 -16
Lines 56650 55031 -1619
==========================================
- Hits 30533 29647 -886
+ Misses 23679 23001 -678
+ Partials 2438 2383 -55
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 6, 2022
* Revert "chore: change id to use uint64 in `AccountAddressByID` (#13411)" This reverts commit 3d0e214. * Add since * Update CLI command * make proto-gen * id->accNum * No API breaking changes * improve err msg * Update CHANGELOG.md Co-authored-by: Julien Robert <julien@rbrt.fr> * Update CHANGELOG.md Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: Julien Robert <julien@rbrt.fr> (cherry picked from commit 90bd316) # Conflicts: # CHANGELOG.md # api/cosmos/auth/v1beta1/query.pulsar.go # api/cosmos/auth/v1beta1/query_grpc.pb.go # api/cosmos/distribution/v1beta1/query_grpc.pb.go # api/cosmos/group/v1/types.pulsar.go # proto/cosmos/auth/v1beta1/query.proto # x/auth/client/cli/query.go # x/auth/keeper/grpc_query.go # x/auth/keeper/grpc_query_test.go # x/auth/types/query.pb.go # x/distribution/types/query.pb.go
amaury1093
added a commit
that referenced
this pull request
Oct 6, 2022
#13460) (#13461) * refactor: Improve and clarify API around `AccountAddressById` (#13460) * Revert "chore: change id to use uint64 in `AccountAddressByID` (#13411)" This reverts commit 3d0e214. * Add since * Update CLI command * make proto-gen * id->accNum * No API breaking changes * improve err msg * Update CHANGELOG.md Co-authored-by: Julien Robert <julien@rbrt.fr> * Update CHANGELOG.md Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: Julien Robert <julien@rbrt.fr> (cherry picked from commit 90bd316) # Conflicts: # CHANGELOG.md # api/cosmos/auth/v1beta1/query.pulsar.go # api/cosmos/auth/v1beta1/query_grpc.pb.go # api/cosmos/distribution/v1beta1/query_grpc.pb.go # api/cosmos/group/v1/types.pulsar.go # proto/cosmos/auth/v1beta1/query.proto # x/auth/client/cli/query.go # x/auth/keeper/grpc_query.go # x/auth/keeper/grpc_query_test.go # x/auth/types/query.pb.go # x/distribution/types/query.pb.go * fix conflicts * changelog Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Wryhder
pushed a commit
to Wryhder/cosmos-sdk
that referenced
this pull request
Oct 26, 2022
…#13460) * Revert "chore: change id to use uint64 in `AccountAddressByID` (cosmos#13411)" This reverts commit 3d0e214. * Add since * Update CLI command * make proto-gen * id->accNum * No API breaking changes * improve err msg * Update CHANGELOG.md Co-authored-by: Julien Robert <julien@rbrt.fr> * Update CHANGELOG.md Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: Julien Robert <julien@rbrt.fr>
JeancarloBarrios
pushed a commit
to agoric-labs/cosmos-sdk
that referenced
this pull request
Sep 28, 2024
cosmos#13460) (cosmos#13461) * refactor: Improve and clarify API around `AccountAddressById` (cosmos#13460) * Revert "chore: change id to use uint64 in `AccountAddressByID` (cosmos#13411)" This reverts commit 3d0e214. * Add since * Update CLI command * make proto-gen * id->accNum * No API breaking changes * improve err msg * Update CHANGELOG.md Co-authored-by: Julien Robert <julien@rbrt.fr> * Update CHANGELOG.md Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: Julien Robert <julien@rbrt.fr> (cherry picked from commit 90bd316) # Conflicts: # CHANGELOG.md # api/cosmos/auth/v1beta1/query.pulsar.go # api/cosmos/auth/v1beta1/query_grpc.pb.go # api/cosmos/distribution/v1beta1/query_grpc.pb.go # api/cosmos/group/v1/types.pulsar.go # proto/cosmos/auth/v1beta1/query.proto # x/auth/client/cli/query.go # x/auth/keeper/grpc_query.go # x/auth/keeper/grpc_query_test.go # x/auth/types/query.pb.go # x/distribution/types/query.pb.go * fix conflicts * changelog Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does 2 things:
AccountAddressByID#13411 (comment), and add some proto commentsq auth address-by-acc-num(keep old version as an alias)Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change