Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DONOTMERGE: poc with ScalarDescriptor #13466

Closed
wants to merge 5 commits into from
Closed

Conversation

amaury1093
Copy link
Contributor

@amaury1093 amaury1093 commented Oct 6, 2022

Description

ref: #13407


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@amaury1093 amaury1093 mentioned this pull request Oct 6, 2022
2 tasks

// Proposal 2: (similar to Dan's `hint` idea)
amino_encoding: "Use base64 to encode this field" // Some human-readable string on how to encode this field.
// TODO Or do we prefer machine-readable? e.g. `base64`
Copy link
Contributor

@pyramation pyramation Oct 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is cool! would be great to have amino_encoding: "base64" so we can just parse it directly.

perhaps we can add a description field or the dev can comment to help add context

@amaury1093
Copy link
Contributor Author

superseded by #13501

@amaury1093 amaury1093 closed this Oct 11, 2022
@amaury1093 amaury1093 deleted the am/scalars-descriptors branch October 11, 2022 09:52
proto/wasm/v1/tx.proto Outdated Show resolved Hide resolved
@amaury1093 amaury1093 reopened this Oct 31, 2022
@amaury1093 amaury1093 closed this Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants